Code Review Workflow
Standards and process for code reviews.
Pull Request Processโ
Before Opening a PRโ
- Rebase on latest
develop - Ensure all tests pass locally
- Run linting:
yarn lint - Self-review your diff
- Write a clear PR description
PR Templateโ
## What Changed
Brief description of changes.
## Why
Business context or issue reference.
## How to Test
1. Step-by-step testing instructions
2. Expected outcomes
## Screenshots
Before/after if UI changes.
## Checklist
- [ ] Tests added/updated
- [ ] Documentation updated
- [ ] No console.log statements
- [ ] Types properly defined
Reviewer Checklistโ
| Area | Check |
|---|---|
| Logic | Correct business logic |
| Security | No vulnerabilities introduced |
| Performance | No N+1 queries, proper indexes |
| Types | Proper TypeScript types |
| Tests | Adequate test coverage |
| Naming | Clear variable/function names |
| Error Handling | Proper exception handling |
| Tenant Scoping | tenantId properly applied |
Review Response Timesโ
| Priority | Target Response |
|---|---|
| Critical | < 2 hours |
| Normal | < 24 hours |
| Low | < 48 hours |
Related Pagesโ
- Git Workflow โ branching model
- CI Test Pipeline โ CI checks
- Development Guide โ setup